Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update whitehall-admin to redirect "/government/uploads/*path.:extension" to asset-manager #219

Closed
chrisroos opened this issue Sep 20, 2017 · 1 comment
Closed

Update whitehall-admin to redirect "/government/uploads/*path.:extension" to asset-manager #219

chrisroos opened this issue Sep 20, 2017 · 1 comment
Milestone
Serve Whitehall n...

Comments

@chrisroos
Copy link
Contributor

We'll need to make sure this happens at the same time we deploy the changes to Puppet that change the nginx config to send requests for /government/uploads to asset-manager (e.g. using an environment variable to toggle the behaviour).
@chrisroos chrisroos added this to the Store and serve Whitehall images in/from Asset Manager milestone Sep 20, 2017
@chrisroos
Copy link
Contributor Author

chrisroos commented Jan 31, 2018 •
edited

I think this can be closed. I'm relatively confident we're generating full URLs (i.e. including the asset-manager host) in whitehall-admin. We can always open a new issue if we find any examples of this not happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Serve Whitehall non-attachment assets...
Development

No branches or pull requests
1 participant
@chrisroos