bugfix: going from previous address to confirm removes the option to … #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…go to previous address again
MattBidewell
force-pushed
the
Bugfix-back-breaks-going-from-previous-to-confirm
branch
from
bea07fc
to
09a8c29
Compare
|
Kudos, SonarCloud Quality Gate passed! |
merlinc
approved these changes
May 19, 2022
MattBidewell
deleted the
Bugfix-back-breaks-going-from-previous-to-confirm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
Change the logic that shows the radio buttons which prompt for more information.
Why did it change
Previous logic, would only show the button when the user hadn't been into the previous journey and when they triggered the more information logic.
This proves to be a problem when entering the previous address journey and then returning back to the confirmation page. A simple fix for this is to only show the radio buttons when we dont have any previous addresses and the validFrom value trips the more information logic. This way they should always end up seeing the radio button as long as they dont add an additional address and the date they provide is recent.