Make missing manifests more alarming #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a problem in DOS 5 where we forgot to update admin-frontend, so some DOS 5 manifests could not be loaded. There were info-level logs warning us about this, but they were missed in amongst the other info-level logs warning of (expected) missing manifests. Make the expected missing manifests less prominent by moving them to debug level. Other missing manifests are not expected - move them to error level to make them more noticible.
lfdebrux
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a problem in DOS 5 where we forgot to update admin-frontend, so some DOS 5 manifests could not be loaded. There were info-level logs warning us about this, but they were missed in amongst the other info-level logs warning of (expected) missing manifests.
Make the expected missing manifests less prominent by moving them to debug level. Other missing manifests are not expected - move them to error level to make them more noticible.