Utils error handlers and templates for Brief Responses #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
approved these changes
Aug 10, 2018
|
Functional tests seem OK locally - let's merge and find out... |
katstevens
deleted the
372-your-session-has-expired-instead-of-ugly-csrf-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/kqjkCP72/101-move-csrf-session-expired-message-to-utils
Trying out the new error handling and templates in the Brief Responses FE.
I've added a couple of tests in
test_applicationas examples to check that 1) the CSRF error handler is being invoked correctly 2) the 400.html toolkit template is being used. There are more comprehensive tests for each common exception class/error template in the utils repo.