Use mypy to test typing #1284
Merged
Use mypy to test typing #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh dear. We've hit python/mypy#9656. |
Maybe we should just pin to the older version of mypy and hope they find a way around this issue? |
|
Agreed. There is a workaround (assign the lambda to a variable), but it's a bit silly. |
We will use this to test our type hints
Also internal libraries that don't yet have type hints.
There were lots of typing errors, and I don't want to fix them all now.
As picked up by mypy
Fix what errors I could. I ignored the errors that are due to the slightly weird thing we do with attributes.
The will mean that it gets run by CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
mypystatic type checking to the checks performed onmake testand on Travis CI (but not on commit).I've also fixed/ignored the issues mypy picked up as appropriate.
I copied the approach from dmrunner, which we did first.