Merge pull request #328 from alphagov/ris-mc-subscribe-robust

DMMailChimpClient: make subscribe_new_email_to_list more robust to exceptions

dmutils/__init__.py

@@ -4,4 +4,4 @@
 import flask_featureflags  # noqa
 
 
-__version__ = '28.0.2'
+__version__ = '28.0.3'

dmutils/email/dm_mailchimp.py

@@ -75,7 +75,9 @@ def subscribe_new_email_to_list(self, list_id, email_address):
             # mailchimp to never add them to mailchimp lists. In this case, we resort to allowing a failed API call (but
             # log) as a user of this method would unlikely be able to do anything as we have no control over this
             # behaviour.
-            if "looks fake or invalid, please enter a real email address." in e.response.json()["detail"]:
+            if getattr(e, "response", None) and (
+                "looks fake or invalid, please enter a real email address." in e.response.json()["detail"]
+            ):
                 self.logger.error(
                     "Expected error: Mailchimp failed to add user ({}) to list ({}). API error: The email address looks fake or invalid, please enter a real email address.".format(  # noqa
                         hashed_email,