Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notice Component uses heading element with no following content #442

Closed
vanitabarrett opened this issue Aug 11, 2017 · 1 comment
Closed

Notice Component uses heading element with no following content #442

vanitabarrett opened this issue Aug 11, 2017 · 1 comment

Comments

@vanitabarrett
Copy link
Contributor

The notice component accepts text with no description. When this happens, the text is rendered in a heading element. This is incorrect use of a heading element.

Leonie has suggested the following:

<section aria-label="Notice">
    <p>Statistics release cancelled</p>
</section>
@fofr fofr mentioned this issue Aug 15, 2017
Merged
@vanitabarrett vanitabarrett mentioned this issue Aug 17, 2017
Merged
@fofr
Copy link
Contributor

fofr commented Oct 7, 2017

Fixed by #451

@fofr fofr closed this as completed Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fofr @vanitabarrett