Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lead in line to list example #1013

Closed
edwardhorsford opened this issue Aug 7, 2019 · 4 comments · Fixed by #1014
Closed

Add lead in line to list example #1013

edwardhorsford opened this issue Aug 7, 2019 · 4 comments · Fixed by #1014

Comments

@edwardhorsford
Copy link
Contributor

The GOV.UK style guide requires that unordered lists have a lead in line. The guidance says as much, but the example doesn't include one. Since it's always expected to be there, I think it would be helpful to include in the example.

Current:

Screenshot 2019-08-07 at 12 54 20

Proposed:

Screenshot 2019-08-07 at 12 57 03

@edwardhorsford
Copy link
Contributor Author

I also raised an issue on the design system backlog about the lead in line being really far from the bullets - but possibly I'm not marking it up correctly - another reason to show a coded example of the lead in line.

@NickColley NickColley added the awaiting triage Needs triaging by team label Aug 7, 2019
@NickColley
Copy link
Contributor

For other core styles we have some contextual changes, so we could consider doing the same here, it's not without risk but worth thinking about.

@kellylee-gds kellylee-gds removed the awaiting triage Needs triaging by team label Aug 7, 2019
@timpaul
Copy link
Contributor

timpaul commented Aug 7, 2019

Hi @edwardhorsford - thanks for this. Would you be interested in raising a pull request to update the example as per your suggestion (here's the relevant file)? We'd like to leave the lead line margin as it is though, as this is currently the style across the whole of GOV.UK and there are currently no plans to change this.

@edwardhorsford
Copy link
Contributor Author

@timpaul pr raised. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants