Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional reveal radio component has aXe errors #524

Closed
injms opened this issue Aug 31, 2018 · 2 comments
Closed

Conditional reveal radio component has aXe errors #524

injms opened this issue Aug 31, 2018 · 2 comments

Comments

@injms
Copy link

injms commented Aug 31, 2018

The aXe accessiblity tool flags two issues when using the conditional reveal radio component. Running aXe on the example page shows the following issues:


Elements must only use allowed ARIA attributes

<input class="govuk-radios__input" id="how-contacted-conditional-1" name="how-contacted" type="radio" value="email" aria-controls="conditional-how-contacted-conditional-1" aria-expanded="false">

To solve this violation, you need to:

Fix the following:

  • ARIA attribute is not allowed: aria-expanded="false"

Radio inputs with the same name attribute value must be part of a group

<input class="govuk-radios__input" id="how-contacted-conditional-1" name="how-contacted" type="radio" value="email" aria-controls="conditional-how-contacted-conditional-1" aria-expanded="false">

To solve this violation, you need to:

Fix at least one (1) of these issues:

  • All elements with the name "how-contacted" do not reference the same element with aria-labelledby
  • Fieldset contains unrelated inputs

I think the expected behaviour would be to have no critical issues flagged by aXe - unless this is a false alarm or is found not to have any impact after testing in the empathy lab.

@36degrees
Copy link
Contributor

Hi Ian,

Thanks for raising – as this more of an implementation issue, would you mind raising it over on the Frontend repo?

(For context, this is something that's come up before in alphagov/govuk_elements#455, but we don't currently have it recorded on the Frontend repo)

Thanks,

Ollie

@NickColley
Copy link
Contributor

I have moved this issue, thanks for raising :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants