Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radio button background not grey on de-select #54

Closed
robmckinnon opened this issue Jan 23, 2015 · 2 comments
Closed

Radio button background not grey on de-select #54

robmckinnon opened this issue Jan 23, 2015 · 2 comments

Comments

@robmckinnon
Copy link

Radio button backgrounds are no longer being re-greyed on de-select in the radio button section of the GOV.UK elements guide:
screen shot 2015-01-23 at 11 58 23
screen shot 2015-01-23 at 11 58 35
screen shot 2015-01-23 at 11 58 43

Checkboxes are not effected by this issue. They are still being re-greyed on de-select.

The changes to selection-buttons.js in this commit may have introduced the radio button issue.
@robmckinnon robmckinnon mentioned this issue Jan 23, 2015
Closed
@gemmaleigh
Copy link
Contributor

Hi @robmckinnon, thanks for pointing this out - I'll fix those examples now.

@gemmaleigh gemmaleigh mentioned this issue Jan 23, 2015
Merged
@gemmaleigh
Copy link
Contributor

Closing as fixed - all the form examples are now wrapped in <form> elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robmckinnon @gemmaleigh