Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: add a 'positive' colour. #386

Closed
edwardhorsford opened this issue Feb 27, 2017 · 5 comments
Closed

Proposal: add a 'positive' colour. #386

edwardhorsford opened this issue Feb 27, 2017 · 5 comments

Comments

@edwardhorsford
Copy link
Contributor

There are cases where it's useful to have a colour with a semantic meaning of 'positive'.

We already have error_colour which is a good red for 'negative' - but we don't have a counterpart.

We could use an existing colour, or make a new colour. Either way, a semantic SASS name would be good.

The closest colour would be button_colour. An alternate would be #008800 which is the green used by petitions. It's warmer, which feels more positive to me.

screen shot 2017-02-27 at 16 55 19

Thoughts?

@NickColley
Copy link
Contributor

@edwardhorsford since this is in response to 'done' pages' use of turquoise, should we show how this colour would be used and also see if we should deprecate the turquoise?

@edwardhorsford
Copy link
Contributor Author

@NickColley it's related, but isn't in response to that - it's something I've thought about a few times before.

@kr8n3r
Copy link

kr8n3r commented Feb 9, 2018

@edwardhorsford shall we raise this in Frontend and close here?

@edwardhorsford
Copy link
Contributor Author

@igloosi yes that's probably a good idea.

@kr8n3r
Copy link

kr8n3r commented Feb 9, 2018

closing in favour of issue in govuk-frontend

@kr8n3r kr8n3r closed this as completed Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants