Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organisations list mislabels Trial orgs as Billable #450

Closed
46bit opened this issue Oct 2, 2019 · 0 comments · Fixed by #455
Closed

Organisations list mislabels Trial orgs as Billable #450

46bit opened this issue Oct 2, 2019 · 0 comments · Fixed by #455

Comments

@46bit
Copy link
Contributor

46bit commented Oct 2, 2019

The org view of https://admin.london.cloud.service.gov.uk/organisations/a8e32de1-b0a0-4a00-b36b-6324a0ba35cf says it is a Trial org:

Screen Shot 2019-10-02 at 10 57 41

But on the homepage's list of organisations it is said to be a Billable org:

Screen Shot 2019-10-02 at 10 58 33

In fact, the homepage's list of organisations describes every org as Billable 😮

I glanced at the underlying code and it looked OK, but I suspect the comparison is subtly hiding a problem. The comparison in both locations is if quota name equals 'default' then say 'Trial' else say 'Billable'. If the quota name isn't actually set then it would say Billable for every org, just like we're seeing on the homepage…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant