Add policy and consultations email alert signup #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable us to publish the email signup page for the policy and consultation finder. It can be published with: FINDER_CONFIG=policy_and_engagement.yml EMAIL_SIGNUP_CONFIG=policy_and_engagement_email_signup.yml publishing_api:publish_finder Publication will need to wait for these two PRs: alphagov/govuk-content-schemas#868 alphagov/finder-frontend#936 Trello: https://trello.com/c/QYU40Ezk/286-publish-consultations-finder-from-rummager-s
|
I can't leave a review note on the description, great idea to put the command to run in the description but omitted rake, it should be |
oscarwyatt
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable us to publish the email signup page
for the policy and consultation finder.
It can be published with:
Publication will need to wait for these two PRs:
alphagov/govuk-content-schemas#868
alphagov/finder-frontend#936
Trello: https://trello.com/c/QYU40Ezk/286-publish-consultations-finder-from-rummager-s