Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slimmer::Cache is not threadsafe #105

Closed
pixeltrix opened this issue Dec 18, 2014 · 1 comment
Closed

Slimmer::Cache is not threadsafe #105

pixeltrix opened this issue Dec 18, 2014 · 1 comment

Comments

@pixeltrix
Copy link
Contributor

The implementation of the cache is not threadsafe because the implementation of Hash in Ruby isn't threadsafe. You'll be fine if you're just using MRI but you may experience issues on other rubies like JRuby.

Probably best to use an existing threadsafe cache like ActiveSupport::Cache::MemoryStore or use ThreadSafe::Cache from the thread_safe gem.
@tijmenb
Copy link
Contributor

tijmenb commented Feb 22, 2017

Closed via #183.

@tijmenb tijmenb closed this as completed Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixeltrix @tijmenb