Do not set parent keymap of magit-todos-section-map #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @alphapapa, do you mind merging this? It is causing magit-todos to be broken in Spacemacs otherwise. |
This is not necessary to make the regular magit-status keys work in the TODOs section. In fact, it causes a bug when used with evil-collection, which uses x instead of k for delete (so that k can move the cursor up one line). Setting the parent keymap unnecessarily confuses evil-collection and causes k to attempt to delete the "thing" at point instead of scrolling up.
alphapapa
force-pushed
the
fix-k-in-evil
branch
from
485af4c
to
9f0d904
Compare
|
Hi Aaron, Thanks for the reminder. I didn't realize it was affecting that many users. I rebased your branch on top of 1.7.1 and released it as v1.7.2, and merged it to master as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not necessary to make the regular magit-status keys work in
the TODOs section.
In fact, it causes a bug when used with evil-collection, which uses x
instead of k for delete (so that k can move the cursor up one line).
Setting the parent keymap unnecessarily confuses evil-collection and
causes k to attempt to delete the "thing" at point instead of
scrolling up.