Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong outline-regexp value inside a php block with web-mode #58

Open
MaxLanar opened this issue Feb 15, 2019 · 1 comment
Open

wrong outline-regexp value inside a php block with web-mode #58

MaxLanar opened this issue Feb 15, 2019 · 1 comment

Comments

@MaxLanar
Copy link

Hi,

when I edit a php (only) file with web-mode major mode, the value of outline-regexp still matches html comments, therefore outshine obviously doesn't work (with php commented headings).

outshine work great with web-mode outside php blocks, but outline-regexp isn't updated as the comment syntax change. It's a problem with php only files where I need to use php comments for headings.

I have no idea if it is a limitation of outshine, a bug, or if I'm supposed to set things myself (in the latter case I have no idea how to make outshine works automatically in both cases, inside and outside php blocks). Any comment appreciated.

emacs 27.0.50
outshine: 20190131.535

@alphapapa
Copy link
Owner

Hi,

I don't know how web-mode works, but I guess its outline-regexp only matches HTML comments. I don't think this is a bug, but just a limitation of how outline-minor-mode and/or outshine work. There isn't a facility to support multiple independent outline-regexp values.

You could try changing the regexp to one that would match both HTML and PHP comments. If that works, you might consider submitting it as a patch to web-mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants