Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate operator implementation templates #32

Closed
nopeslide opened this issue Jun 30, 2020 · 0 comments · Fixed by #34
Closed

generate operator implementation templates #32

nopeslide opened this issue Jun 30, 2020 · 0 comments · Fixed by #34

Comments

@nopeslide
Copy link
Collaborator

nopeslide commented Jun 30, 2020

Just thought that we could also generate the files included inside src/operators/implementation (i.e. operator__onnx__relu__6__T_tensor_float.c) from the Python script. So we can avoid manually creating them. Maybe all types is too much by now, so I would create only the float variants.

Quite useful also if someone wants to implement an operator. If the file and function is already in place (but empty) would be easier for someone without much knowledge of the code to implement and operator. We can abstract them from the complexity of running the Python script and so on.

Originally posted by @alrevuelta in #18 (comment)

@nopeslide nopeslide changed the title generate operator templates generate operator implementation templates Jun 30, 2020
@nopeslide nopeslide linked a pull request Jul 10, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant