Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about upmix plugin #25

Closed
krumpfwylg opened this issue Jun 11, 2021 · 2 comments
Closed

Question about upmix plugin #25

krumpfwylg opened this issue Jun 11, 2021 · 2 comments

Comments

@krumpfwylg
Copy link

Hi, I've noticed the latest commits done to the upmix plugin, but there's something I don't understand.
Line 24 of pcm_upmix.c is #define UPMIX_PCM_FORMAT SND_PCM_FORMAT_S16
Does that mean the upmix plugin is still only capable of using S16_LE format ?
Or does the UPMIX_PCM_FORMAT value can get changed to S32_LE by tweaking it in asoundrc file ?

@perexg
Copy link
Member

perexg commented Jun 11, 2021

Hi, I've noticed the latest commits done to the upmix plugin, but there's something I don't understand.
Line 24 of pcm_upmix.c is #define UPMIX_PCM_FORMAT SND_PCM_FORMAT_S16
Does that mean the upmix plugin is still only capable of using S16_LE format ?

Yes. But you can change source.

Or does the UPMIX_PCM_FORMAT value can get changed to S32_LE by tweaking it in asoundrc file ?

No.

@perexg perexg closed this as completed Jun 11, 2021
@krumpfwylg
Copy link
Author

In the future, would that be possible for the upmix plugin to get the format information S16/S32/other (with a default set to S16) from the asoundrc file, allowing the user to change format in a more friendly way than having to patch & recompile ?
Thanks for answers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants