Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdajackretask doesn't check for script's exit code #8

Open
kroq-gar78 opened this issue Sep 6, 2021 · 1 comment
Open

hdajackretask doesn't check for script's exit code #8

kroq-gar78 opened this issue Sep 6, 2021 · 1 comment

Comments

@kroq-gar78
Copy link

kroq-gar78 commented Sep 6, 2021

hdajackretask creates a script in /tmp before executing it. When /tmp is mounted with noexec, running that script will fail, but the GUI gives no indication that it failed.

I'm on Ubuntu 18.04.5, with alsa-tools-gui package version 1.1.3-1.

The GUI should check for the exit code of the script, and notify the user appropriately if the script failed to execute.

Also, if this isn't the appropriate place to report a bug, please let me know!

@kroq-gar78
Copy link
Author

At hdajackretask/apply-changes.c:98, it looks like we get the exit code, but don't actually check it. Am I understanding this right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant