Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding swift3 and cocoapods #3

Merged
merged 6 commits into from Dec 15, 2016
Merged

adding swift3 and cocoapods #3

merged 6 commits into from Dec 15, 2016

Conversation

mbalex99
Copy link
Contributor

Here's a proper Swift 3.x and Cocoapods Implementation

@mbalex99 mbalex99 mentioned this pull request Dec 15, 2016
@alsedi alsedi self-requested a review December 15, 2016 14:00
Alex Sergeev added 2 commits December 15, 2016 15:07
- License note
- Podspec removed (need to be submitted separately). This branch is about Swift 3 only
@alsedi
Copy link
Owner

alsedi commented Dec 15, 2016

I reviewed the PR and find several issues. To reduce waiting time I fixed issues on my side.

  • Original demo project were restored. Example submitted with PR is overcomplicated and doesn't provide better overview of RippleEffectView. Also it adds additional dependencies that doesn't make use of RippleEffectView clearer.
  • Texts in cocoa pods synced with GitHub (nothing special, just tune up)
  • Cocoapods file removed from PR, because it fails on lint validation. That is more important it's too different from Swift 3 and need to be submitted as separate PR.

@alsedi alsedi merged commit 76f14ee into alsedi:master Dec 15, 2016
Repository owner locked and limited conversation to collaborators Dec 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants