Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String instead of Number like in ASProgressPopUpView #16

Closed
appicus opened this issue May 7, 2014 · 3 comments
Closed

String instead of Number like in ASProgressPopUpView #16

appicus opened this issue May 7, 2014 · 3 comments

Comments

@appicus
Copy link

appicus commented May 7, 2014

Hello,

you have an option in your other project "ASProgressPopUpView" to write a string instead of a formatted number value. Is it possible to add this option to the "ASValueTrackingSlider" too?

Example from "ASProgressPopUpView":

  • (NSString *)progressView:(ASProgressPopUpView *)progressView stringForProgress:(float)progress
    {
    NSString *s;
    if (progress < 0.2) {
    s = @"Just starting";
    } else if (progress > 0.4 && progress < 0.6) {
    s = @"About halfway";
    } else if (progress > 0.75 && progress < 1.0) {
    s = @"Nearly there";
    } else if (progress >= 1.0) {
    s = @"Complete";
    }
    return s;
    }

Thanks!
Kenan.

@alskipp
Copy link
Owner

alskipp commented May 7, 2014

Hi @appicus,
Thanks for your interest in the project. Yes, this is something I definitely need to add, so I'll make sure it's in the next update. As the implementation has already been worked out in ASProgressPopUpView, it shouldn't be too challenging. There might be a bit of refactoring required, but I'll try and get a release out within the next week.

Cheers,
Al

@alskipp
Copy link
Owner

alskipp commented May 8, 2014

Thanks for your suggestion. The functionality has now been merged into master

Cheers,
Al

@alskipp alskipp closed this as completed May 8, 2014
@appicus
Copy link
Author

appicus commented May 9, 2014

Thanks again, this is a very usable control and looks very nice!

Cheers,
Kenan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants