Skip to content
This repository has been archived by the owner on Mar 6, 2021. It is now read-only.

Note for upgrading #87

Closed
dereuromark opened this issue Oct 27, 2017 · 10 comments
Closed

Note for upgrading #87

dereuromark opened this issue Oct 27, 2017 · 10 comments

Comments

@dereuromark
Copy link
Contributor

One issue remains when upgrading internally to php7.1 and if using phpmyadmin:

inside /etc/nginx/sites-available/cakebox.phpmyadmin

fastcgi_pass    unix:/var/run/php/php5...-fpm.sock;

the php version needs to be replaced to work:

php7.1-fpm.sock

Otherwise http://cakebox.phpmyadmin will not work out of the box then.
Maybe this can be added to the upgrade script?

@bravo-kernel
Copy link
Contributor

@dereuromark did I include phpmyadmin in the default set of applications? If so, this should not be too difficult to implement. I will investigate once I find some time.

@dereuromark
Copy link
Contributor Author

Low prio, yeah.

@bravo-kernel
Copy link
Contributor

To make sure I provisioned a fresh box and even though phpmyadmin is used as an example in the docs... phpmyadmin is not included by default so auto-patching is outside of this repo's responsibility.

There two ways I verified are:

  1. Running this command inside the box does not produce any results:

    apt list --installed | grep admin
  2. There are no packages in the extra section of the default Cakebox.yaml file. See line https://github.com/alt3/cakebox/blob/dev/Cakebox.yaml.default#L38

@bravo-kernel
Copy link
Contributor

Could it be phpmyadmin was re-provisioning using your customized Cakebox.yaml?

@dereuromark
Copy link
Contributor Author

Either way, any new app added via "application add" will also have the outdated line in the generated /sites-available/ file.. Always needs manual fixing afterwards.

@dereuromark
Copy link
Contributor Author

We should reopen
Even after removing all nginx files, fresh 7.1 and then reload --provision
we still have the issue of the php5 part in there.

Always need to run

sed -i 's|/var/run/php5-fpm.sock|/var/run/php/php7.1-fpm.sock|g' file.local

afterwards on those files :/

@bravo-kernel
Copy link
Contributor

Happy to reopen. Can you explain what the issue is/is causing then? There are no php5 pointers in any of the directories that seem relevant:

  • grep -rn '/etc/nginx/' -e 'php5'
  • grep -rn '/cakebox/' -e 'php5'

@bravo-kernel bravo-kernel reopened this Dec 2, 2017
@dereuromark
Copy link
Contributor Author

dereuromark commented Dec 2, 2017

I wonder where they come from then, the sites-available/ dir is empty, after reload the files contain the php5 parts.

We should also increase the client_max_body_size, e.g. adding

client_max_body_size 32M;

inside server{} block by default

PS: I am on the latest dev-dev branch.

@dereuromark
Copy link
Contributor Author

I still face this issue with a complete freshly installed php7.2 from master today.
It creates files with the above 5.x reference, I need to use

sed -i 's|/var/run/php5-fpm.sock|/var/run/php/php7.2-fpm.sock|g' file.local

or manually adjust to make it work.

@bravo-kernel
Copy link
Contributor

Closing as I cannot reproduce. A fresh box produces the expected:

fastcgi_pass    unix:/var/run/php/php7.2-fpm.sock;

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants