Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make loading decent and do not block the whole window #1172

Closed
simPod opened this issue Jan 27, 2020 · 5 comments
Closed

Make loading decent and do not block the whole window #1172

simPod opened this issue Jan 27, 2020 · 5 comments

Comments

@simPod
Copy link

simPod commented Jan 27, 2020

When I press Send Request button the overlay is displayed over the whole window:

image

There could be eg. a spinner in the button instead so I can edit query / read previous result / do something else in the window while waiting for query response. Currently it's not possible to do any of that.

@imolorhe
Copy link
Collaborator

Hey @simPod, choosing to block the entire window was an intentional decision. I feel It is easier to block user interaction from the window than to explain to the user that changes made while loading wouldn't have an effect on the running query. Also a spinner in the button isn't a sufficient visual indicator of loading activity.

However I'll check for other UX patterns for this. Do you know of any other alternative UX patterns that would fit this use case? 🙂

@stale
Copy link

stale bot commented Mar 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 29, 2020
@simPod
Copy link
Author

simPod commented Mar 29, 2020

IMO this behaviour is more user friendly https://www.graphqlbin.com/v2/6RQ6TM

When you click the request button, the spinner blocks response window. Also the running request can be cancelled by clicking the request button again. I can still edit my query while request is running there.

@stale stale bot removed the wontfix label Mar 29, 2020
@imolorhe
Copy link
Collaborator

Okay, I'll take a look at this.

@imolorhe imolorhe added this to the v2.4.6 milestone Mar 29, 2020
@simPod
Copy link
Author

simPod commented Mar 31, 2020

wow nice, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants