Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Altair with the system theme #1236

Closed
tudoramariei opened this issue Apr 25, 2020 · 3 comments
Closed

Sync Altair with the system theme #1236

tudoramariei opened this issue Apr 25, 2020 · 3 comments
Milestone

Comments

@tudoramariei
Copy link
Contributor

tudoramariei commented Apr 25, 2020

Is your feature request related to a problem? Please describe.
Many people use an automatic way of setting their OS theme to dark or light (me included) since you don't want to always have the same colour for your apps but also because sometimes it might not be good for your eyes.

Describe the solution you'd like
An option in the settings where you can have Altair sync with the system settings

i.e. if the system settings change the theme from dark to light, Altair would also switch to the system theme

Considering the current options, the best choice would be to have the following choices:

  • light
  • dark
  • dracula
  • system (with an optional selector to pick the preferred dark theme)
@open-collective-bot
Copy link

Hey @tudoramariei 👋,

Thank you for opening an issue. We will get back to you as soon as we can.
Also, check out our Open Collective and consider backing us - every little help counts!

@imolorhe
Copy link
Collaborator

Hey @tudoramariei, Altair currently selects the right theme for you based on your system settings by default. So if you have your system set to use dark mode, when you open Altair fro the first time, it would set your theme to dark theme for you automatically.

@tudoramariei
Copy link
Contributor Author

I wasn't clear enough here, what I wanted was to have Altair constantly sync with the system theme. So that when sunset comes and the computer changes to dark mode Altair would also switch (same for sunrise).

@tudoramariei tudoramariei changed the title Add syncing with system settings for the theme Sync Altair with the system theme Apr 25, 2020
@imolorhe imolorhe added this to the v2.4.7 milestone Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants