Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI is completely broken in Firefox 66.0.2 for 2.1.5 #703

Closed
janflyborg opened this issue Apr 3, 2019 · 18 comments
Closed

UI is completely broken in Firefox 66.0.2 for 2.1.5 #703

janflyborg opened this issue Apr 3, 2019 · 18 comments
Labels
Milestone

Comments

@janflyborg
Copy link

janflyborg commented Apr 3, 2019

The UI is totally garbled in the latest release for Firefox. Please see the attached screenshot.
This is on macOS 10.14.4.

Screenshot 2019-04-03 at 11 22 53

@welcome
Copy link

welcome bot commented Apr 3, 2019

👋🏾Thanks for opening your first issue here! Be sure to follow the issue template! ✌🏾

@imolorhe
Copy link
Collaborator

imolorhe commented Apr 3, 2019

It looks like there are errors. Could you check the console for any errors?

Also set __ENABLE_DEBUG_MODE__ to true in your console and see show the logs here as well.

@janflyborg
Copy link
Author

The browser more or less hangs when I open the console, but I could spot an endless number of lines with this:
ERROR TypeError: "n.gqlSchema is null

@imolorhe
Copy link
Collaborator

imolorhe commented Apr 3, 2019

Okay. I'm guessing your previous version was 2.1.4?

@janflyborg
Copy link
Author

janflyborg commented Apr 3, 2019

I guess so. The add-ons are automatically updated by Firefox, so I'm usually not really aware of which version of each extension I'm using (as long as they are working), but I was using the previous version without any problems and then there was an update today (or yesterday) and the UI became garbled.

@imolorhe
Copy link
Collaborator

imolorhe commented Apr 3, 2019

Any chance you got the file along with the line number and column no? The only new change between the two versions involving gqlSchema is v2.1.4...v2.1.5 but I haven't been able to reproduce the issue. The line no:column no would help me narrow it down better.

Note: You can easily fix it now by clearing your local storage (which would clear all your open windows) but as this is the only instance of this issue right now, I would rather you didn't 😅

@janflyborg
Copy link
Author

I have already downloaded the standalone version of Altair, so let's first fix this issue and then I can delete the local storage... 😀

This is the complete error:
ERROR TypeError: "n.gqlSchema is null" main.81280f8f66c4fddd066b.js:1:1100610

@imolorhe
Copy link
Collaborator

imolorhe commented Apr 3, 2019

@imolorhe
Copy link
Collaborator

imolorhe commented Apr 3, 2019

Unfortunately even the line number didn't help to find the exact error. I would add extra checks in the code as a measure to potentially fix this.

@imolorhe imolorhe added the bug label Apr 3, 2019
@janflyborg
Copy link
Author

So I guess I can clean my local storage now and we'll wait for it to happen again when you have the extra checks put into place?

@janflyborg
Copy link
Author

janflyborg commented Apr 4, 2019

FYI I just started my Ubuntu at work computer which now runs the latest version of Altair without any problems (also on the latest Firefox). The only difference (apart from my home machine being a Mac) is that I have not messed with the look and feel at this instance.

@imolorhe
Copy link
Collaborator

imolorhe commented Apr 4, 2019

Yes you can. The issue is related to potentially corrupted data in the storage, so it wouldn't affect most instances neither would it affect new instances.

@janflyborg
Copy link
Author

OK. Thanks for the help so far.

@tmtrademarked
Copy link

I'm seeing something similar in Chrome using the Chrome extension, FWIW. I'm using Altair 2.1.5 in Chrome 73.0.3683.86 on Mac, and I get the weird gibbrish I see below. I was able to use this a few days ago, so I wonder if somehow 2.1.5 created a bad state in certain circumstances? I'll hold off clearing local storage for right now in case this is useful to help debug.

Screen Shot 2019-04-04 at 7 01 37 PM

@tmtrademarked
Copy link

With debug mode on, it tells me I was using 2.1.3 previously.

@imolorhe
Copy link
Collaborator

imolorhe commented Apr 5, 2019

Is it possible that you have a specific schema from your graphQL server that makes Altair to break?

@tmtrademarked
Copy link

Certainly possible - but the same schema worked in the browser extension a few days ago, and also works in the stand alone desktop app, which makes me think that's unlikely. :-/

@imolorhe imolorhe added this to the v2.1.6 milestone Apr 5, 2019
@imolorhe
Copy link
Collaborator

imolorhe commented Apr 7, 2019

v2.1.6 has been published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants