Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabSize not working #741

Closed
Badyl1g opened this issue Apr 24, 2019 · 3 comments
Closed

tabSize not working #741

Badyl1g opened this issue Apr 24, 2019 · 3 comments
Milestone

Comments

@Badyl1g
Copy link

Badyl1g commented Apr 24, 2019

Describe the bug
When I change the tabSize in settings it doesn't affect anything, the value is saved in settings, but clicking on "prettify" still uses default tabSize. The problem also occurs in Altair chrome extension.

To Reproduce
Steps to reproduce the behavior:

  1. Open Settings
  2. Change "tabSize" to any number
  3. Click "Save"
  4. Try to prettify the query

Expected behavior
Updated tabSize value should properly prettify the query

Desktop:

  • OS: Windows 10 (desktop app)
  • Version 2.1.7
@welcome
Copy link

welcome bot commented Apr 24, 2019

👋🏾Thanks for opening your first issue here! Be sure to follow the issue template! ✌🏾

@imolorhe
Copy link
Collaborator

Hey @Badyl1g thanks for reporting this issue.

The tab size currently doesn't affect the prettify functionality. I should be able to add that.

@Badyl1g
Copy link
Author

Badyl1g commented Apr 25, 2019

I think it also should affect the response to make it more readable

@imolorhe imolorhe added this to the v2.1.8 milestone May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants