docs: Use Facet/Trellis/Repeat consistently #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See vega#3178 This removes the old trellis_area example, because that is just a simpler version of the sorted version. Might as well just have the sorted version, it is easy enough to see how you would jusst remove the sort to get back to the original example. This also adds some commas to the code so that black keeps the formatting the same. I wanted to update the name of the example so that it didn't contain the word "trellis". While I was at it I also wanted the examples to be in better sort order.
See vega#3178 This also re-categorizes this example as a case study. I think this makes more sense, as it puts it with the other beckers barley example. And there aren't really any advance calculations going on.
This isn't an example of faceting, but repeating. See vega#3178
The scatter plot is not faceted, but the marginal scatter plots are, with one histogram for eadch subset. See vega#3178
This is using faceting, so let's call it out explicitly so people learn the terminology. See vega#3178
See vega#3178 Also improve the intro to Faceted charts.
NickCrews
commented
Aug 30, 2023
| import pkgutil | ||
|
|
There was a problem hiding this comment.
Oops, isort got in here. I can revert if you want...
joelostblom
approved these changes
Sep 15, 2023
|
Thanks for the review! I recognize these giant blobs of text are intimidating to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3178
(tracking for me)