Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform minor consistency cleanup #3215

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Perform minor consistency cleanup #3215

merged 2 commits into from
Oct 3, 2023

Conversation

joelostblom
Copy link
Contributor

Just some minor things I cam across during the release process

@joelostblom joelostblom marked this pull request as ready for review October 3, 2023 18:28
@@ -19,7 +19,7 @@ Version 5.1.2 (released Oct 3, 2023)
----------------------------------------

- Update Vega-Lite from version 5.14.1 to version 5.15.1;
see `Vega-Lite Release Notes <https://github.com/vega/vega-lite/releases>`_.
see `Vega-Lite 5.15.1 Release Notes <https://github.com/vega/vega-lite/releases/tag/v5.15.1>`_.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We get some "duplicate key" warnings without this; maybe harmless but might as well avoid them

Copy link
Contributor

@mattijn mattijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joelostblom joelostblom merged commit cf7bdbd into main Oct 3, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants