[Doc] Fix Chart and MarkDef language #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelostblom
force-pushed
the
fix_markdef_boxplot
branch
from
0ffcf6d
to
082bc4a
Compare
|
Thank @ChiaLingWeng ! I did some minor formatting and rebased on main. I opened a follow up issue for the VL docstring in #3370. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #2545,
where the usage should be alt.Chart(df, mark=alt.CompositeMarkDef(type='boxplot'))
this PR update definition in https://altair-viz.github.io/user_guide/generated/toplevel/altair.Chart.html,
but for MarkDef in https://altair-viz.github.io/user_guide/generated/core/altair.MarkDef.html
Seems like it's generated from vega-lite-schema and I might need some instruction on where to start