Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to work on colab almost effectively except some functionalities #22

Merged
merged 7 commits into from Nov 8, 2020

Conversation

alihussainia
Copy link
Contributor

I have updated the widget.py file and based on my modifications, the altair_widgets are running on colab and plus I was able to run a demo colab notebook in which I have shown the working of the altair_widgets with a local customized package based on this pull request widget.py.Demo Colab Link

Copy link
Member

@stsievert stsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

altair_widgets/widget.py Outdated Show resolved Hide resolved
@stsievert
Copy link
Member

@alihussainia I've added the commands to the README, and removed other files. Does that look good to you?

@alihussainia
Copy link
Contributor Author

Thank you, brother @stsievert it is fine for me but I would say that what if the commands are added to the widget.py file as if you test the widget.py file along with these commands on regular jupyter notebooks and if they won't give any error then it will be good addition to the widget.py especially for those who are looking forward to use it on colab by directly importing the project via pip :)

@stsievert
Copy link
Member

I've made some changes; now, I issue a warning if the notebook is running on colab, and point to the docs. Would that address the issue?

@alihussainia
Copy link
Contributor Author

@stsievert awesome amigo! Thanks bro. I thought I would also become a contributor to the repo but its fine :) thanks for your time and consideration.

Best wishes,

Muhammad Ali

@alihussainia
Copy link
Contributor Author

Should I close the PR?

@stsievert stsievert merged commit 20f6659 into altair-viz:master Nov 8, 2020
@stsievert
Copy link
Member

Perfect, I've merged this PR into 20f6659 (which we co-authored).

@alihussainia
Copy link
Contributor Author

Thank you, Thank you so much brother! You just made my day amigo. I am truly happy and grateful to you for this favor brother. Please share your linkedin id too, I would definitely like to connect with such an awesome brother of mine.

Thanks once again brother.

Muhammad Ali
Your brother and now a contributor too <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants