Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove top-level menu #36

Closed
gnestor opened this issue Apr 19, 2018 · 4 comments
Closed

Remove top-level menu #36

gnestor opened this issue Apr 19, 2018 · 4 comments

Comments

@gnestor
Copy link
Contributor

gnestor commented Apr 19, 2018

I don't think it makes sense to display a top-level "Voyager" in all contexts. The original top-level menu in lab took this approach (there was a "Console" and "Editor" menu that were visible regardless of whether you were working in a notebook, editor, or terminal) and then it was revised to be more general (with "File", "Edit", and "Kernel" menus) and now all of the sub-menu items change based on context. I think it totally makes sense to use context menus and command palette commands for this extension because they can be made available based on the context. The only issue is that they're invisible to the user, so even though the user is probably aware that the extension is installed, he/she may forget and potentially not use it.

I created a commit to remove the menu bar, do with it what you see fit: c73a908

@zzhangjii
Copy link
Collaborator

Hi, @gnestor , thanks for the advice
On planning, I will start the user testing next week, so this top-menu bar serves as an alternative option for user to choose, I will record the user's habits and make a summary.
The ideal design would probably be put functional buttons(save, saveas, undo, redo...) into something like the tool-bar inside notebook:
screen shot 2018-04-19 at 12 52 47 pm
I'm working on it right now.

And as you mentioned, without the top-menu-bar, voyager-extension is pretty much invisible, plus we do need a place to put voyager-tutorial for users, therefore, I suggest we keep it until the user testing is over.

@gnestor
Copy link
Contributor Author

gnestor commented Apr 19, 2018

Oh ya, toolbar could be very nice 👍

@zzhangjii
Copy link
Collaborator

Note, now the top 'Voyager' menu is gone
the tutorial page goes into 'Help';
the "open in voyager" is combined with file context menu;
the "open vl.json in notebook" is added into the vl.json file context menu;
all save/export and show/hide toolbar are inside the context menu of voyager interface

@gnestor
Copy link
Contributor Author

gnestor commented May 17, 2018

Thanks @zzhangjii! Much better 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants