-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove top-level menu #36
Comments
Hi, @gnestor , thanks for the advice And as you mentioned, without the top-menu-bar, voyager-extension is pretty much invisible, plus we do need a place to put voyager-tutorial for users, therefore, I suggest we keep it until the user testing is over. |
Oh ya, toolbar could be very nice 👍 |
Note, now the top 'Voyager' menu is gone |
Thanks @zzhangjii! Much better 👍 |
I don't think it makes sense to display a top-level "Voyager" in all contexts. The original top-level menu in lab took this approach (there was a "Console" and "Editor" menu that were visible regardless of whether you were working in a notebook, editor, or terminal) and then it was revised to be more general (with "File", "Edit", and "Kernel" menus) and now all of the sub-menu items change based on context. I think it totally makes sense to use context menus and command palette commands for this extension because they can be made available based on the context. The only issue is that they're invisible to the user, so even though the user is probably aware that the extension is installed, he/she may forget and potentially not use it.
I created a commit to remove the menu bar, do with it what you see fit: c73a908
The text was updated successfully, but these errors were encountered: