Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor EDDI say invocations #22

Closed
alterNERDtive opened this issue Jun 23, 2020 · 0 comments
Closed

Refactor EDDI say invocations #22

alterNERDtive opened this issue Jun 23, 2020 · 0 comments
Assignees
@alterNERDtive
Labels
done implemented, but not merged into release yet EliteAttack enhancement New feature or request
Milestone
1.5

Comments

@alterNERDtive
Copy link
Owner

The other profiles are already doing that properly (because they have to check if EDDI is used or not), but there’s no real reason not to do it properly here, too. Just to make sure that the global SCRIPT variable is only fiddled with right before the plugin call.
@alterNERDtive alterNERDtive added enhancement New feature or request EliteAttack labels Jun 23, 2020
@alterNERDtive alterNERDtive added this to the 1.5 milestone Jun 23, 2020
@alterNERDtive alterNERDtive self-assigned this Jun 23, 2020
@alterNERDtive alterNERDtive added the done implemented, but not merged into release yet label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alterNERDtive alterNERDtive

Labels
done implemented, but not merged into release yet EliteAttack enhancement New feature or request
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
1 participant
@alterNERDtive