timeZonesDB being released

[rschmunk]

I've been giving APTimeZones a tryout. Along with the wrong TZ errors that others have reported for many US locations, I was running into a problem with a crash because of memory being released if I tried to look up more than one location. The problem seems to be that the timeZonesDB property in APTimeZones is not retained and was getting released between lookups.

In the importDataBaseFromFile method, the DB array is created using

NSArray *timeZones = [NSJSONSerialization JSONObjectWithData:jsonData
                                                    options:NSJSONReadingAllowFragments
                                                    error:&error];

I fixed the crashing problem by changing that to

NSArray *timeZones = [[NSJSONSerialization JSONObjectWithData:jsonData
                                                    options:NSJSONReadingAllowFragments
                                                    error:&error] retain];

Also, it looks to me like there is another potential memory bug in the APTimeZones class in the closesZoneInfoWithLocation method. Memory for a zoneLocation object is allocated every time through the loop,

    CLLocation *zoneLocation = [[CLLocation alloc] initWithLatitude:latitude longitude:longitude];

but is never released.

[Krivoblotsky]

APTimeZones requires ARC, and seems to be your are not using it. Just switch it to use ARC, and you will get rid of all crashes and memory issues. I will update the documentation to point on this.

[rschmunk]

Ah, that makes sense, and also explains some other oddities that I ran into elsewhere in the APTimeZones class. And as it was, I later realized I was putting that retain I added in the wrong place.

Thanks for the fast response.