Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why can't I reproduct the effect on the paper #10

Closed
akafen opened this issue Jul 30, 2018 · 5 comments
Closed

Why can't I reproduct the effect on the paper #10

akafen opened this issue Jul 30, 2018 · 5 comments

Comments

@akafen
Copy link

akafen commented Jul 30, 2018

Hello,I use your code to run,but ths psnr always is 35.x tested on Set5 which the scale factor is 2 ,but the paper is 38.09.I wonder why?

@alexnie1997
Copy link

Can you run all the 5 images of Set5? I can only run three of them.

@alterzero
Copy link
Owner

Hi @akafen , How did you calculate the PSNR? In the paper, the measurement used luminance layer only.

@alexnie1997 We use TITAN X. If you have less memory, try to run the evaluation using --chop_forward True (This function is implemented by EDSR team https://github.com/thstkdgus35/EDSR-PyTorch)

@akafen
Copy link
Author

akafen commented Jul 31, 2018

Hi @alterzero,I calculated the PSNR on RGB images,but I think it should not have such a big difference and I would try to calculate the PSNR using luminance layer only.

@wehkjhkl
Copy link

Can you run eval.py?how can you do it?

@LoSealL
Copy link

LoSealL commented Jan 14, 2019

@akafen The difference could be up to 2dB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants