Set LAN interface even if none exist #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drozdziak1
approved these changes
Oct 2, 2018
|
@asoltys Sounds good, I'd appreciate if you could adjust this PR for that. Thanks! |
|
I moved the string parsing into the Kernel but decided that rather than adding a new error type to return it makes more sense to just return Ok() with an empty string if the uci setting wasn't found. |
jkilpatr
reviewed
Oct 3, 2018
|
also why where there three commits that undo each other? Just cherry pick the second one and lets go for it. |
|
Ok, rebased |
asoltys
dismissed
drozdziak1’s stale review
@jkilpatr said lets just keep the error checking in the calling code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where if you had removed all LAN interfaces you wouldn't be
able to re-add one since the network.lan.ifname setting wouldn't exist and the
code would return an Err in that case.
Now if the setting doesn't exist, we go ahead and set it instead of returning
an Err.