Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: If melos run analyze fails, it will still be a success. #54

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

riscait
Copy link
Member

@riscait riscait commented Jan 24, 2024

πŸ™Œ What I did

  • Fix "export ordering"
  • Fix melos run analye

✍️ What I didn't do

βœ… Verification

  • Android
  • iOS
  • macOS
  • Web

Screenshots

Additional Information

@riscait riscait requested a review from a team as a code owner January 24, 2024 02:01
@riscait riscait requested review from naipaka and removed request for a team January 24, 2024 02:01
@riscait riscait requested review from k-nkmr and removed request for naipaka January 24, 2024 02:01
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffs generated by melos bs.

@riscait riscait changed the title Fix-ignore-analyze-failed fix: If melos run analyze fails, it will still be a success. Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (d77dca9) 54.27% compared to head (2a07ae0) 54.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   54.27%   54.27%           
=======================================
  Files          11       11           
  Lines         269      269           
=======================================
  Hits          146      146           
  Misses        123      123           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@k-nkmr k-nkmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riscait riscait merged commit 7946aad into main Jan 24, 2024
7 checks passed
@riscait riscait deleted the fix-ignore-analyze-failed branch January 24, 2024 02:20
@riscait riscait requested a review from naipaka January 24, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants