Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getters at IVehicle #28

Closed
Kalcor1337 opened this issue Apr 23, 2021 · 3 comments
Closed

Getters at IVehicle #28

Kalcor1337 opened this issue Apr 23, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Kalcor1337
Copy link

Don't you think that the getters in IVehicle should add the const qualifier? And in general, all interfaces seem to need to add noexcept.
@LeonMrBonnie LeonMrBonnie added enhancement New feature or request good first issue Good for newcomers labels Apr 23, 2021
@LeonMrBonnie
Copy link
Contributor

I agree about the part with the const qualifier, if someone has some free time they could add them.
Unsure about the noexcept tho

@martonp96
Copy link
Contributor

Hi Maxim @Kalcor1337,
Please open a pull request instead of creating issues.

@FabianTerhorst
Copy link
Contributor

Got fixed in #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@FabianTerhorst @martonp96 @LeonMrBonnie @Kalcor1337