Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

altwebsocket-sharp is not linked to the driver nuget package #1192

Closed
RobertPoienar opened this issue Mar 30, 2023 · 6 comments
Closed

altwebsocket-sharp is not linked to the driver nuget package #1192

RobertPoienar opened this issue Mar 30, 2023 · 6 comments
Assignees
Labels
bug Something isn't working release pro 2.0.0 Label that targets the first release for AltTester Pro

Comments

@RobertPoienar
Copy link
Contributor

RobertPoienar commented Mar 30, 2023

Steps to reproduce

  1. Create a nunit project
  2. Add AltDriver package inside it
  3. Instantiate an AltDriver
  4. Run the default test

Actual result

AR

Throws the error that can be seen in the screenshot

Additional info

image

Expected result

Building the test project will be successful and will start running the test.
Then driver will connect to the server( if there is a running server) or will throw an error that it could not connect.

Additional info

Testability

Try following the steps to reproduce and see if the Expected result happens

@RobertPoienar RobertPoienar added bug Something isn't working release pro 2.0.0 Label that targets the first release for AltTester Pro labels Mar 30, 2023
@RobertPoienar RobertPoienar changed the title altwebsocket-sharp is linked to the driver nuget package altwebsocket-sharp is not linked to the driver nuget package Mar 30, 2023
@RobertPoienar RobertPoienar self-assigned this Mar 30, 2023
@ralupopa
Copy link

ralupopa commented Apr 5, 2023

Reproduced after adding AltTester-Driver --version 1.8.2 nuget package

But seems to work (not reproducing) using 1.8.0

dotnet add package AltTester-Driver --version 1.8.0

@pavel-tds
Copy link

@ralupopa solution works, but it is not a fix

@ralupopa
Copy link

ralupopa commented Apr 13, 2023

LE: managed to get altwebsocket-sharp.dll from here and put in my project's bin 👍


@RobertPoienar

Do you have some temporary workaround in order to be able to use SDK 1.8.2 installed as package?


what I tried so far:

  • add this
    image

  • install it as package manually

dotnet add package WebSocketSharp --version 1.0.3-rc11

Maybe because name changed, need somehow to have altwebsocket-sharp.dll, but don't know how.

@RobertPoienar
Copy link
Contributor Author

As a workaround you can do the following:

  1. Download the dll from: https://github.com/alttester/AltTester-Unity-SDK/blob/development/Assets/AltTester/3rdParty/websocket-sharp/netstandard2.0/altwebsocket-sharp.dll
  2. Add the file in your project
  3. In your csproj file add the following:
    <Reference Include="AltWebSocketSharp"> <HintPath>altwebsocket-sharp.dll</HintPath> </Reference>

HintPath - is the path where your dll is, it doesn't really need to be in your project.

image

@RobertPoienar
Copy link
Contributor Author

@iulianatodoran This ticket will be tested only after the new release is deployed on Nuget. It will remain in testing until then after #1224 is merge

@iulianatodoran
Copy link
Collaborator

iulianatodoran commented May 25, 2023

Testing environment

  • IDE : VSCode
  • AltTester-Driver package for AltTester Unity SDK v.2.0.0 (released)
  • AltTester Desktop v.2.0.0 (fort starting AltServer) from development branch (24.05.23)

Tests performed and results

Checked that by following the steps describes in the ticket, the expected result is achieved:

  • ✅ Building the test project is successful and started running the test successfully
  • ✅ The driver connected to the running server and the default test passed

Conclusion

The purpose of this ticket was achieved: the issue is not reproducible anymore.

Closing the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release pro 2.0.0 Label that targets the first release for AltTester Pro
Projects
None yet
Development

No branches or pull requests

4 participants