-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDBC lock not working with PSQL due to SQL syntax #26
Comments
same issue with sqlserver:
|
I currently don't have the time to tackle this, if any of you have time to solve this, I would be happy to merge a PR. |
Hi Guys, I tried to create a pull request, but I've got some errors. Maybe it is because of firewall issues. public static final String ACQUIRE_FORMATTED_QUERY = "INSERT INTO %s (lock_key, token, expireAt) VALUES (?, ?, ?)"; Best Regards, |
@cipianpascu that was the first version of the queries. The issue is that |
Oh, I didn't know. But that is a small/corner case. No one will use the name 'lock' in production for a table. I propose to change the default to something else. For example 'tbl_lock' or 'table_lock' or anything else that is not interfering with the sql sintax. |
Should be fixed in 1.5.0, I decided to change the default table name as suggested to avoid further complications |
not yet. sadly I get ORA-00933: SQL command not properly ended in this moment |
It seems like it might be due to the semicolon at the end? I released a new fix version, could you try with that one? (1.5.1) |
Hey Alen, |
Hi, the recent changes to the SQL query for MySql is causing PSQL syntax errors.
It seems to be that the inclusion of " ` " is breaking PSQL syntax.
Not too sure on a fix, but it looks like MySql and PSQL syntax are conflicting, would appreciate if you could look into this.
Thanks.
The text was updated successfully, but these errors were encountered: