Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm package #2

Closed
abrahm opened this issue Jun 23, 2017 · 2 comments
Closed

npm package #2

abrahm opened this issue Jun 23, 2017 · 2 comments

Comments

@abrahm
Copy link

abrahm commented Jun 23, 2017

Aluan,

The current aurelia-types-installer npm package has CRLF EOLs in all the files. I'm guessing it was packaged on windows with git config core.autocrlf=true, which means that the bin/ati script as-packaged won't run on *NIX platforms because a carriage return ends up on the shebang line.

There is a fairly easy workaround, I just had to manually remove the carriage return from bin/ati after npm installed the package.

I suspect doing git config core.autocrlf input on windows might keep the newlines *NIX friendly for packaging on npm. (You can refresh an existing checkout by deleting .git/index followed by git reset... git status should then show what looks different without the autocrlf applied at checkout).

This isn't really a bug, but if you wanted to you could read this as an enhancement request to add a .gitattributes to maybe avoid this problem in the future.

Some similar discussion can be found at npm issue 2097.

Have a nice day!

@aluanhaddad
Copy link
Owner

aluanhaddad commented Jun 25, 2017

@abrahm, thank you for the bug report, it is much appreciated.

The CI builds run in Linux environments but they invoke the entry point directly using ts-node instead of hitting the bin/ati script.

Thank you for the detailed analysis and for explaining how to resolve the problem.

@aluanhaddad
Copy link
Owner

aluanhaddad commented Jun 25, 2017

I ended up going the .gitattributes route, great tip by the way.

I drafted release 0.2.8 to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants