Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addToLibrarySearchPath breaks when value is not an array #94

Open
grabbou opened this issue May 27, 2016 · 2 comments
Open

addToLibrarySearchPath breaks when value is not an array #94

grabbou opened this issue May 27, 2016 · 2 comments

Comments

@grabbou
Copy link

grabbou commented May 27, 2016

https://github.com/alunny/node-xcode/blob/master/lib/pbxProject.js#L1146. On this line we only check if value is $(inherited) and convert it to an array otherwise. I've seen projects that have other, non $(inherited) single value there, which causes the script to break with .push is undefined since the value will be a string.

I think we could just replace that check with !Array.isArray() which should make it more future proof.

@imhotep
Copy link
Collaborator

imhotep commented May 29, 2016

@grabbou you are welcome to send a pull request for this one with a test that reveals the failure.

@Tiagojdferreira
Copy link

Tiagojdferreira commented Jul 25, 2016

Similar for addToOtherLinkerFlags #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants