-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot fullscreen a YouTube video in a section with scrollOverflow #2804
Comments
Issue also occurs with other iframe-based video players (JWPlayer, etc) |
Same problem! |
So guys any suggestions? I find somewhere in the StackOverflow post - where the guy writes :
But i don't really understand how can i do it ? |
He might be refereeing to |
nope, the first his message was:
Then he add an aswer:
I tried to use setAllowScrolling(false); but its not helps |
We're running up against this issue with a Vimeo iframe. Has anybody made any progress on ameliorating the problem? |
FWIW, we see the same problem with the non-iFrame native video players in all browsers. |
Ok. We got this working. We need to do more testing before hanging up the Victory banner, but here's the change that made it work:
We'll be further testing this today, if we see any issues with it we'll post again. I hope this helps out! @alvarotrigo You may want to consider including this change in an update. |
Sure! Feel free to create a Pull Request explaining the issue it solves and how it works. |
Hello! In my current case YouTube embedded iframes won't go fullscreen if placed within the FullPageJS markup. They may flick and leave the page full black, the video won't play. It seems a bit unpredictable what the result would be, sometimes nothing really happens, the fullscreen video flicks and then disappear. Outside FullPageJS, in other pages, they work as usual, just fine. ps. The issue seems to be present only on Chrome and Safari. Firefox so far plays along fairly well. |
@carlorizzante working as expected on this demo. See the 2nd section: https://jsfiddle.net/5yLsdwmt/20/ |
Thanks for the prompt reply, @alvarotrigo, I finally managed to make it work on Chrome and Safari. The issue seemed to be related to some absolute positioning of the background on the slides, so unlikely related to FullPageJS. Thanks for a great piece of code by the way :) |
@ alvarotrigo |
@e-anima please search with the keyword "video" on the forum. There's nothing new I have to say about it. |
Fixed in v4! 👍 |
Description
If you have a YouTube video embedded within a section which has scrollOverflow enabled and content of a sufficient length to make it scrollable, the video cannot be made fullscreen. When you try, the fullscreen video flashes up briefly, but then returns to normal size.
Link to isolated reproduction with no external CSS / JS
http://jsfiddle.net/rredfearn32/xdw4j8xg/
Steps to reproduce it
Versions
Desktop issue.
Present on most common browsers (Chrome, Firefox, Safari, IE) and OS's (Windows, OSx, Ubuntu)
The text was updated successfully, but these errors were encountered: