New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fancybox with scroll doesn't work #3435
Comments
Try placing it inside the fullpage wrapper and using the option |
@alvarotrigo i changed demo. Now it works on desktop, but doesn't work on mobiles correctly. |
Try using |
@alvarotrigo the same bug :( have updated demo |
Try adding the fancybox element inside the active section instead. |
Doesn't work Updated |
Hi, I am using full page 3.0 and fancybox v3 first and then I've tested with fancybox v2, in both when it shows fancybox I cant scroll in fancybox, instead of page behind scrolls to other sections but not large content in fancybox. used these: when fires fancybox to avoid scroll on page sections, but dosn't work, any idea? //others comment |
Testing it on Chrome dev tools with the touch mobile view seems to work as expected now. |
https://codepen.io/taras-khvyl/full/BqzXpw/ - tested in incognito mode with touch mobile view. Doesn't work. Scroll works only after you touch opened popup. But right after opening popup scroll doesn't work |
You mean right after closing it? |
No. After popup opened scroll doesn't work. But after you touch once on popup on any place (not close) scroll works fine. |
any ideas on it ? :( |
I'll have to take a look with more calm. I click the link. It opens the popup. I click and drag. It moves up and down. |
i recorded short video. when i move up/down i am clamping a mouse and scroll doesn't work. after i click on popup and it works |
upd: now after closing popup fullpage sections scroll doesn't work |
any updates? |
Nop. Haven't looked again at it yet. |
The issue should be fixed now in the dev branch 3.0.4. It will get merged for the next release 3.0.4 |
Now fixed in fullPage.js 3.0.4! |
@alvarotrigo, good day, thanks of all the awesome work you're putting in! I'm facing the following problem both in the CodePen demo you shared and in the project I'm working on while I'm in mobile environment: After closing the FancyBox popup I can't use the drag or the mouse scroll to change to another section (I get stuck on the section with the popup). To paraphrase it, the scroll works as intended inside the popup but stops working for the sections the moment I close the popup. I can change the sections with the keyboard's arrows or anchors. Cheers and best of wishes! :) |
@ValentinGenev you said:
But then you mention:
I'm confused. |
You would also need to provide device details, OS and browsers in which you are having the issue.. |
Thank you for the reply and apologies for the confusion. I'm running in the mentioned issue on an Android 4.2.2 device with Chrome (version: 71.0.3578.99) and on the Chrome (72.0.3626.109 (Official Build) (64-bit)) on my PC (Windows 7 Ultimate), where I use the mentioned keyboard arrows. I'm testing while the Chrome's DevTools device toolbar is toggled. I managed to reproduce similar behavior in Firefox (65.0.1 (64-bit)) too; where I use the Responsive Design Tool. In that last case the issue manifests itself as inability to change sections with the mouse scroll (since there isn't drag function or I don't know how to activate it). I hope I cleared most of the confusion. I'm aware that the mobile device I'm testing on is very old and the other environments are simulations at best so I hope this is more of an isolated case. Thanks again. Edit: Some more context in this gif: http://sitesandbox.eu/general/scroll_example.gif |
Can you reproduce your issue on the codepen provided in the first message of this topic? |
Yes, I can and I tried on both my phone and my PC using Chrome (the mentioned versions). |
I'll then re-open the issue. |
This issue is related with #3576 and it has been solved on the dev branch. It will get merged in fullpage.js 3.0.5. |
This issue has been fixed in the latest fullPage.js release 3.0.5! |
Description
When open modal with height bigger than height of screen, scroll in fancybox popup doesn't work on desktop and mobiles.
Link to isolated reproduction with no external CSS / JS
https://codepen.io/taras-khvyl/pen/BqzXpw
Steps to reproduce it
Versions
Windows 10 [Google Chrome v.69.0.3497]
Android 8.0.0 [Google Chrome]
The text was updated successfully, but these errors were encountered: