Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When scrolloverflow is set to true, Cannot make the vimeo video fullscreen #4104

Closed
mohomedanees opened this issue Nov 11, 2020 · 9 comments
Closed

Comments

@mohomedanees
Copy link

Hi I've set to scrolloverflow: true that will automatically enable scroll wherever it's needed. But how can I get rid of this when open an iframe video which is vimeo or youtube in fullscreen the video is getting closed in fullpage.

How can I resolve this issue?

new fullpage('#fullpage', {
anchors: anchors,
navigation: true,
css3: true,
navigationPosition: 'right',
bigSectionsDestination: 'top',
scrollOverflow: true,
scrollOverflowReset: true,
scrollingSpeed: 800,
easingcss3: 'cubic-bezier(.455, .03, .515, .955)',
});

And I'm trying to use this function when on fullscreen and exit from fullscreen.
$(window).resize(checkResize);

      function checkResize() {
        if (
          document.fullscreenElement ||
          document.webkitFullscreenElement ||
          document.mozFullScreenElement ||
          document.msFullscreenElement
        ) {
          console.log('full');
          fullpage_api.reBuild();
        } else {
          console.log('fullexit');
          fullpage_api.reBuild();
        }
      }

This didn't work either. How can I fix this. I think this should be a fix in fullpage.js with scrollOverflow: true.

Please help me to resolve this issue.

@alvarotrigo
Copy link
Owner

It's a problem on the external library used by fullpage.js for scrolloverflow.
I reported it long time ago on iScroll.js but the library hasn't been maintained since.

Try passing this options on the fullpage.js option scrollOverflowOptions:

scrollOverflowOptions: {
	click: false,
	preventDefaultException: { tagName:/.*/ }
},

Or this:

scrollOverflowOptions: {
	click: true,
	preventDefaultException: { tagName:/.*/ }
},

@alvarotrigo
Copy link
Owner

Related with #2837

@mohomedanees
Copy link
Author

Hi Alvaro,

The solution above also didn't work either.

@alvarotrigo
Copy link
Owner

Also related with #2139.
I would recommend you researching a bit on the iScroll issues forum.

@mohomedanees
Copy link
Author

Thank you Alvaro.

@mohomedanees
Copy link
Author

Alvaro I would say it's better for you to change the plugin that you use for fullpage.js if the scroll plugin in not maintained anymore.

@alvarotrigo
Copy link
Owner

Easy to say, not as easy to do :)
But yeah perhaps in a future.

@mohomedanees
Copy link
Author

I know it's a hard thing. If you change it no more issues with iScroll then 😄

@alvarotrigo
Copy link
Owner

Fixed on v4! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants