Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile scroll and language #4262

Closed
IcEWaRRiOr01 opened this issue Sep 8, 2021 · 9 comments
Closed

Mobile scroll and language #4262

IcEWaRRiOr01 opened this issue Sep 8, 2021 · 9 comments

Comments

@IcEWaRRiOr01
Copy link

Description

  1. Mobile swipe scrolling up - down does not work on my mobile device when switching on any language other than English
  2. Mobile scrolling with swipes does not work when resize desktop browser window to mobile using devtools
  3. Some parts of the text are not translated from English when switching language to Russian

Steps to reproduce it

If you resize desktop browser to mobile and try to swipe up - down then swipes will not work.
If you open alvarotrigo.com/fullPage website on mobile browser like Samsung Internet browser or mobile Chrome browser and switch on any language other than English - you will not be able to scroll pages with swipes

Versions

Desktop Firefox version 91.0.2, desktop Chrome version 93.0.4577.63, mobile Samsung Internet browser version 15.0.2.47, mobile Chrome version 92.0.4515.159

@IcEWaRRiOr01
Copy link
Author

P.S: My mobile device - Samsung Galaxy A21s and my desktop OS - Linux Ubuntu

@alvarotrigo
Copy link
Owner

  • Mobile swipe scrolling up - down does not work on my mobile device when switching on any language other than English

Uh! Not good! Thanks for reporting it!
It should be fixed by now! 👍
Reload a couple of times to force the refresh and to avoid getting it from the cache.

Mobile scrolling with swipes does not work when resize desktop browser window to mobile using devtools

I'm not able to reproduce this one. Can you provide the step-by-step process?
Does it happen in both Firefox + Chrome?

Some parts of the text are not translated from English when switching language to Russian

What parts precisely? (check the latest updated version now, in case something changed)
The name of the extensions and the Wordpress plugins should not be translated.

@IcEWaRRiOr01
Copy link
Author

I'm not able to reproduce this one. Can you provide the step-by-step process?
I press F12 on keyboard, then toggle device toolbar by pressing Ctrl + Shift + M, hold down the left mouse button and drag the cursor up - down in desktop browser imitating swipes with the finger on a mobile device.

But now after reloading page error with swiping is disappeared.

What parts precisely?

  1. "is actively maintained and community driven." in first slide on second page
  2. "commits" and "contributors" in stats in the first slide

Menu:
3. In "Examples" - "Continuous vertical" in "Navigation", and all links in "Extensions"
4. In "Pricing" - all content is not translated. By the way, translated word "Pricing" - "Ценообразование" sounds a little incorrectly in russian language, it would be better if it be "Цены" or "Тарифные планы".
5. Incorrectly translated to russian language word "Docs" - "Документы". It would be better if it be "Документация".
6. In Docs the sentence "Available for Vue, React and Angular." is not translated. It would be better if it be "Доступно для Vue, React и Angular" (No need to translate framework names)
7. In Docs too - the sentence "Using Webpack, Browserify or Require.js? Check how to use fullPage.js with module loaders." is not translated.
8. In Docs in "Options" - not translated descriptions of options "dropEffect", "dropEffectOptions", "waterEffect", "waterEffectOptions", "cards", "cardsOptions", "afterReBuild()", and description of header "Sponsors"

@alvarotrigo
Copy link
Owner

alvarotrigo commented Sep 14, 2021

"is actively maintained and community driven." in first slide on second page

Mind sharing the translation with me here?

  1. In "Examples" - "Continuous vertical" in "Navigation", and all links in "Extensions"

Those are the names of the extension.
Would you like the provide the translation for those?

  1. In "Pricing" - all content is not translated.

It is not supposed to be :)
Our resources are limited. Can't be translating all pages. Just doing the main one and the extensions one.

  1. Incorrectly translated to russian language word "Docs" - "Документы". It would be better if it be "Документация".

Fixed!

  1. In Docs the sentence "Available for Vue, React and Angular." is not translated. It would be better if it be "Доступно для Vue, React и Angular" (No need to translate framework names)

Fixed on dev!

  1. In Docs too - the sentence "Using Webpack, Browserify or Require.js? Check how to use fullPage.js with module loaders." is not translated.

Feel free to do a pull request with the translation.

  1. In Docs in "Options" - not translated descriptions of options "dropEffect", "dropEffectOptions", "waterEffect", "waterEffectOptions", "cards", "cardsOptions", "afterReBuild()", and description of header "Sponsors"

Feel free to do a pull request for these too. I don't know Russian :)

@IcEWaRRiOr01
Copy link
Author

And yet - at the first load, the submenu language block is opened, and after clicking outside it, it closes. Should this block be opened on the first page loading, or is it a bug?

@alvarotrigo
Copy link
Owner

Should this block be opened on the first page loading, or is it a bug?

It's designed to be like that. Opened on page load in case the user wants to change language.
Language detection is not always perfect ;)

Let me know if you plan on providing the Russian translations for the docs. Otherwise I'll proceed to close the issue.

@IcEWaRRiOr01
Copy link
Author

Yes, I will write a translation into Russian

@alvarotrigo
Copy link
Owner

I've marked the issue as resolved.
If you plan on providing the other translations please let me know and I'll open the issue again.

@alvarotrigo
Copy link
Owner

Fixed on v4! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants