Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not actually "designed to fit to different screen sizes as well as tablet and" #30

Closed
joeframbach opened this issue Oct 9, 2013 · 4 comments

Comments

@joeframbach
Copy link

I am using a 1366x768 Thinkpad x220t, and page 4 of the demo looks like this:

fullpage

@alvarotrigo
Copy link
Owner

Well, it is designed to fill different screen sizes as it resizes the sections to adjust to it. It also auto adjust the section position on resize or even the landscape slides.

It is also designed for tablets as there are touch controls for them and even an option to disable the auto scrolling.

The result you are getting is exactly the same as if you take yoru dektop computer and resize the browser window on the Y axis making it smaller.

What would be the expected behavior of it?
Should the plugin resize the image? According to what? How does the plugin knows how you want your images to look like? What if i don't want my images to be resized?

Do you actually have any suggestion to solve this "problem"?

The way I see to solve it is using CSS media queries and depending on the resolution loading an image or another. That's the way responsive design is done but that's belong this plugin, it depends on the designer and the design they want to achieve.

@liquidscorpio
Copy link

@alvarotrigo +1

@ekianjo
Copy link

ekianjo commented Oct 11, 2013

Well, technically it does not work as advertised since the pages do not look the same at all when resizing.
I'm not sure why you are saying it's beyond the scope of this script since you do resize the text but you do not resize the images. Either you do not do any resizing or you do both. Doing only one does not really make sense.

Of course on can implement separate queries to load up smaller images to make up for the lack of support but if you had any parameter that could activate this kind of function that would be beneficial to many.

@alvarotrigo
Copy link
Owner

@ekianjo which criteria will you follow to resize the images?
How can I know which size the user want to see the image in an small screen device? Should I resize it depending on the height or on the width of the screen?

I believe it is belong the plugin as this should be done with CSS queries and generating different image sizes for each of the defined resolution the designer wants to play with.

The problem with the given example and the iPad images is already there on desktop computers. It has nothing to do with tablets or mobile devices. The way I designed the demo page is not ready to deal with windows smaller than 720px. It was a design decision as any other which designers take when they create any site.

I could have solved it with CSS queries and it would have worked as expected on the tablet devices as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants