Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitch in the navigation property of pagepiling function object. #160

Open
SakhirAtwi opened this issue Aug 7, 2018 · 3 comments
Open

Comments

@SakhirAtwi
Copy link
Contributor

SakhirAtwi commented Aug 7, 2018

@alvarotrigo The ReadMe file says that,

screenshot_20180808_022517

But if you make navigation property to true then nothing happens, as in the screen shot there is nothing in the right side of browser window,
screenshot_20180808_023519

The reason is by setting the value of property to true you are making it a boolean in the first place which is not what is supposed to happen. you should pass in a empty object for that to work.
Secondly, the property is not false by default either(As written in ReadMe) coz of the lines of code in plugin,

screenshot_20180808_000328

This is checking if object is empty which is not by default in the default configurations object passed to pagepiling function.

Fixes:
1)Either ReadMe can be changed that navigation is by default true(I mean taking in object), not "programmatically true", and you must false it to remove the navigation in the right.
2)Or I have created a pull request which will correct the plugin to use the empty object by defaut(Not creating the navigation) and will create the navigation bar as properties passed to it.

Side-Note: navigation:true is never going to work, coz it contradicts the type of property. Only empty object will be taken up, if taken up.

@SakhirAtwi
Copy link
Contributor Author

SakhirAtwi commented Aug 9, 2018

@alvarotrigo I think its a serious issue to look into, but you seem to be not responding, IDK why.

@alvarotrigo
Copy link
Owner

alvarotrigo commented Aug 9, 2018

Busy with other things at the moment. I'll review it at some point in the future.

@SakhirAtwi
Copy link
Contributor Author

@alvarotrigo alright, best ov luck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants