[ICON] Support for Xfce 4.16 rdns icons.

[darkshram]

This is the current look of xfce4-settings-manager with current Nordzy icon theme. Added some context to the screenshot because some tools are not really from Xfce.

Context: Icons within a red square are not part of Xfce. They are 3rd party tools I just integrated into xfce4-settings-manager because I felt final users may like to find them within a single tool.

This is the new name schema for Xfce 4.16:

Old icon name	New icon name
xfce4-power-manager-settings	org.xfce.powermanager
xfce4-panel	org.xfce.panel
xfce4-panel-menu	org.xfce.panel.applicationsmenu
system-log-out	org.xfce.panel.actions
x-office-calendar	org.xfce.panel.clock
folder	org.xfce.panel.directorymenu
application-x-executable	org.xfce.panel.launcher
xfce4-workspaces	org.xfce.panel.pager
list-remove-symbolic	org.xfce.panel.separator
user-desktop	org.xfce.panel.showdesktop
preferences-system-windows	org.xfce.panel.tasklist
preferences-system-windows	org.xfce.panel.windowmenu
xfce4-session	org.xfce.session
system-log-out	xfsm-logout
system-reboot	xfsm-reboot
system-shutdown	xfsm-shutdown
system-suspend	xfsm-suspend
system-hibernate	xfsm-hibernate
system-suspend-hibernate	xfsm-hibernate
system-users	xfsm-switch-user
preferences-system	org.xfce.settings.editor
preferences-desktop	org.xfce.settings.manager
preferences-desktop-accessibility	org.xfce.settings.accessibility
preferences-desktop-theme	org.xfce.settings.appearance
xfce4-color-settings	org.xfce.settings.color
video-display	org.xfce.settings.display
preferences-desktop-keyboard	org.xfce.settings.keyboard
preferences-desktop-default-applications	org.xfce.settings.preferred-applications
preferences-desktop-peripherals	org.xfce.settings.mouse
edit-find	org.xfce.appfinder
drive-removable-media	org.xfce.volman
Thunar	org.xfce.thunar
preferences-desktop-screensaver	org.xfce.ScreenSaver
utilities-terminal	org.xfce.terminal
utilities-terminal	org.xfce.terminal-settings
accessories-text-editor	org.xfce.mousepad
applets-screenshooter	org.xfce.screenshooter
utilities-system-monitor	org.xfce.taskmanager
xfce4-notifyd	org.xfce.notification
xfce4-dict	org.xfce.Dictionary
catfish	org.xfce.catfish
gtk-network	org.xfce.gigolo
parole	org.xfce.parole
ristretto	org.xfce.ristretto
xfburn	org.xfce.xfburn
xfdashboard	org.xfce.xfdashboard

I have a 'shortcut method' to create the rdns icons. Saves some time and work. First I used the official Xfce list for rdns icons, then created a two column text file with this table data and saved it as ~/new-rdns-icons-xfce4-4.16.txt. Then used the following script, which basically looks for the old xfce4 icons within the src sub-folders, then tries to create a symlink for new rdns icon at the same location. The script only creates the symlink with relative path if the old xfce4 icon (png/svg) does exist and it does not overwrite any previously existent symlink (unless -fsr is used instead of -lr):

cd Nordzy-icon
for dir in `find ./src -type d -name "*"`
do
    cd ${dir} && \
    while read old new
    do
        if [ -e ${old}.png ]; then ln -sr ${old}.png ${new}.png; fi
        if [ -e ${old}.svg ]; then ln -sr ${old}.svg ${new}.svg; fi
    done < ~/new-rdns-icons-xfce4-4.16.txt
    cd -
done
find ./src -type l -name "*" |xargs git add

Simple, but effective. The catch: if there is no previous old Xfce icon, there will not be a new Xfce rdns icon.

There is also this python script https://gist.github.com/bluesabre/582d886a02c793285f4e3081df9b2a3c. Have not tested it, but basically does the same as my bash script, but with harder to read code.

I can make a PR if you want, but I think you may like to play a little with both alternatives to check and test the results.

[alvatip]

I will fix that as soon as I'm over with the other bug 😉
Feel free to create a PR, even thought I don't think any of these icons are already created (well at least none that I remember)... And if this is the case, they are probably symlinks that should be deleted and replaced by a proper icon. 😛

[darkshram]

I tested it yesterday. Some of them are present. This is the list of the new icons created with the script, symlinking to the existent old Xfce icons (still Material/WhiteSur styled).

src/actions/16/org.xfce.appfinder.svg
src/actions/16/org.xfce.panel.actions.svg
src/actions/16/xfsm-logout.svg
src/actions/22/org.xfce.appfinder.svg
src/actions/22/org.xfce.panel.actions.svg
src/actions/22/xfsm-hibernate.svg
src/actions/22/xfsm-logout.svg
src/actions/22/xfsm-shutdown.svg
src/actions/22/xfsm-suspend.svg
src/actions/24/org.xfce.appfinder.svg
src/actions/24/org.xfce.panel.actions.svg
src/actions/24/xfsm-hibernate.svg
src/actions/24/xfsm-logout.svg
src/actions/24/xfsm-shutdown.svg
src/actions/24/xfsm-suspend.svg
src/actions/32/org.xfce.panel.actions.svg
src/actions/32/xfsm-hibernate.svg
src/actions/32/xfsm-logout.svg
src/actions/32/xfsm-reboot.svg
src/actions/32/xfsm-shutdown.svg
src/actions/32/xfsm-suspend.svg
src/actions/32/xfsm-switch-user.svg
src/actions/symbolic/org.xfce.panel.separator.svg
src/apps/scalable/org.xfce.settings.editor.svg
src/apps/scalable/org.xfce.volman.svg
src/devices/16/org.xfce.volman.svg
src/devices/22/org.xfce.volman.svg
src/devices/24/org.xfce.volman.svg
src/devices/scalable/org.xfce.volman.svg
src/mimes/16/org.xfce.panel.clock.svg
src/mimes/16/org.xfce.panel.launcher.svg
src/mimes/22/org.xfce.panel.clock.svg
src/mimes/22/org.xfce.panel.launcher.svg
src/mimes/scalable/org.xfce.panel.clock.svg
src/mimes/scalable/org.xfce.panel.launcher.svg
src/places/16/org.xfce.panel.directorymenu.svg
src/places/22/org.xfce.panel.directorymenu.svg
src/places/24/org.xfce.panel.directorymenu.svg
src/places/scalable/org.xfce.panel.directorymenu.svg
src/places/scalable/org.xfce.panel.showdesktop.svg

Will make a PR before the weekend.

[alvatip]

Sweet, thanks !!