Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journal Infos produced by OpenMW don't merge #5

Open
Willtor opened this issue Feb 13, 2024 · 8 comments
Open

Journal Infos produced by OpenMW don't merge #5

Willtor opened this issue Feb 13, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@Willtor
Copy link

Willtor commented Feb 13, 2024

Failed to process list "tmp.omwaddon, Balmora Club.omwaddon, bc2.omwaddon"

Caused by:
0: Failed to process plugin
1: Failed to process records from plugin "bc2.omwaddon": Error: "4924ff3bafe644ecbe4ad1690d369063" info record's kind is different to "BC_Zyrchyal" dialogue's
Fix the problem or add "--ignore-important-errors"(may rarely cause unexpected behaviour) to ignore

The bc2 plugin has one Journal Topic, "BC_Zyrchyal", and one Journal Info for it, "hello world" (index: 10).

The bc2 plugin works in the OpenMW engine, though I can't test it on the original so I don't know if it works there or not.

@alvazir
Copy link
Owner

alvazir commented Feb 18, 2024

Hello! Thank you. I'll investigate. Looks like a bug on my side.

@alvazir
Copy link
Owner

alvazir commented Feb 18, 2024

I've checked. It's TES3 CS limitation(and probably original engine's). There may be only 1 unique dial name, so that to you have to use another name for different dialogue type.

note that journal topic names and dialogue topics names CANNOT be the same. If they are, you will receive errors.

I want my tool to produce proper results for both engines for now(despite using OpenMW exclusively). The best way in this situation is to rename Journal Dialogue in yoyr bc2.omwaddon to something else.

@Willtor
Copy link
Author

Willtor commented Feb 19, 2024

Aha! Okay -- this makes sense. Let me try that out.

@Willtor
Copy link
Author

Willtor commented Feb 19, 2024

I renamed the Journal topic to Foobarfoobar, but it still generates the same error. It occurred to me that both extensions are still really small so I'm posting them here. BC2, in particular, just has the Journal Topic and one entry for the Name.
extensions.zip

@Willtor
Copy link
Author

Willtor commented Feb 19, 2024

Clarification: It produces the error now regarding Foobarfoobar instead of BC_Zyrchyal.

@alvazir
Copy link
Owner

alvazir commented Mar 3, 2024

I am sorry for taking that much time to reply. Busy days.

Thank you for being persistent on this issue. I've noticed the error, then reproduced it, then found the source of the error.

The problem is due to OpenMW-CS bug. It sets one of the fields incorrectly for dialogue entries. I've reported the issue to OpenMW.

I'll add an option to overcome the bug in OpenMW-CS created plugins.

@alvazir alvazir self-assigned this Mar 3, 2024
@alvazir alvazir added the bug Something isn't working label Mar 3, 2024
@Willtor
Copy link
Author

Willtor commented Mar 3, 2024

Thanks! Yeah, no worries. I 100% get it with the busy. ;)

@alvazir
Copy link
Owner

alvazir commented Apr 1, 2024

Fixed upstream in 0.49.

I am yet to add an option to ignore the error though(plugins made with previous versions of OpenMW-CS would be around for a long time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants