Knative 0.26 ( sources.knative.dev/v1 ) not supported

[draiberg]

When using Knative v0.26 Imaging Operator deployment fails with error message:

controller-runtime.source if kind is a CRD, it should be installed before calling Start {"kind": "SinkBinding.sources.knative.dev", "error": "no matches for kind "SinkBinding" in version "sources.knative.dev/v1alpha2""}
sigs.k8s.io/controller-runtime/pkg/source.(*Kind).Start
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/source/source.go:117
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/internal/controller/controller.go:167
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/internal/controller/controller.go:223
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startRunnable.func1
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/manager/internal.go:681
2021-10-15T20:42:49.960Z ERROR controller-runtime.manager error received after stop sequence was engaged {"error": "no matches for kind "SinkBinding" in version "sources.knative.dev/v1alpha2""}

due to version change in source.knative.dev towards v1.

[jeesmon]

@draiberg Thanks for the report. We will look into it.

[draiberg]

@jeesmon Found references in common/rediness_check.go line 13.

[jeesmon]

Yep, we need to figure out a path to support both knative ships with OpenShift and upstream knative versions. Will keep you updated. Thanks.

[jeesmon]

Knative removed sources.knative.dev/v1alpha2 from v0.23.0: https://github.com/knative/operator/blob/release-0.23/cmd/operator/kodata/knative-eventing/0.23.0/1-eventing-crds.yaml#L39

Need to update knative dependency to atleast v0.19.0 to get v1 API

Knative version in OCP v4.5 is 0.16.0
Knative version in OCP v4.6/v4.7/v4.8/v4.9 is v0.23.0

Path forward:

• Drop support for OCP v4.5 (this version is no longer supported by RH)
• Update knative dependency to v0.23.0+ to be in sync with OCP
• Update doc to reflect minimum knative version required

FYI @rduggan-ibm

[jeesmon]

@draiberg What method were you using to deploy operator? Through OLM or yaml? If yaml, wondering if I can give you a test docker image to try.

[draiberg]

@jeesmon I used the yaml. Happy to test a docker.

[jeesmon]

@draiberg Great, I pushed a new version from the PR at quay.io/jeesmon/imaging-ingestion-operator:0.0.2. Please try and let me know. Thanks a lot.

[draiberg]

@jeesmon Works well, thanks a lot!

[jeesmon]

@draiberg Thanks for confirming. We pushed out v0.0.2 of operator to dockerhub too.

We are also interested in learning your use case. Would you be willing to tell us more details on how you are planning to use this work? We can start a new discussion if you like. Thanks.